Remove dependency on all Roslyn assemblies from build host #73497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
tmat
commented
May 15, 2024
| @@ -1034,8 +1021,8 @@ public static int Sum<T>(this ImmutableArray<T> items, Func<T, int, int> selecto | |||
| where TNamedTypeSymbol : class, TNamespaceOrTypeSymbol | |||
| where TNamespaceSymbol : class, TNamespaceOrTypeSymbol | |||
| { | |||
| foreach (var (name, value) in dictionary) | |||
| result.Add(name, createMembers(value)); | |||
| foreach (var entry in dictionary) | |||
There was a problem hiding this comment.
Avoid dependency on KeyValuePair deconstructor extension
|
@jasonmalinowski @dibarbet @dotnet/roslyn-ide @dotnet/roslyn-compiler ptal |
tmat
commented
May 16, 2024
| @@ -11,45 +11,6 @@ namespace Roslyn.Utilities | |||
| { | |||
| internal static class EnumUtilities | |||
| { | |||
| /// <summary> | |||
There was a problem hiding this comment.
Moved, renamed and simplified
tmat
commented
May 16, 2024
| using System.Text; | ||
|
|
||
| namespace Microsoft.CodeAnalysis | ||
| { | ||
| internal static partial class EncodingExtensions | ||
| { | ||
| /// <summary> |
tmat
commented
May 16, 2024
| @@ -764,19 +764,6 @@ public static ImmutableArray<T> Distinct<T>(this ImmutableArray<T> array, IEqual | |||
| return result; | |||
| } | |||
|
|
|||
| internal static bool HasAnyErrors<T>(this ImmutableArray<T> diagnostics) where T : Diagnostic | |||
dibarbet
approved these changes
May 16, 2024
...Workspaces/Core/MSBuild.BuildHost/Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.csproj
Show resolved
Hide resolved
JoeRobich
approved these changes
May 16, 2024
jaredpar
approved these changes
May 17, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #70945
Reduces size of the Workspace.MSBuild package from 33.5MB down to 4.3MB.
This in turn reduces the size of the .NET SDK and the VS Code Extension by the same amount.
net472:
netcore:
As noted in #70945, the build host only used a handful of compiler types. These types can be easily avoided. The build host also uses quite a few extensions and utilities, which can be linked instead of referenced. To make the linking cleaner this change moves a few types defined in the compiler
InternalUtilitiesthat had dependencies on non-utility Roslyn types elsewhere. This allows the host to simply link to all internal utilities.As a follow up, I believe it would be useful to rename
InternalUtilitiestoFrameworkUtilitiesand treat this code as a layer below the compiler (on the same level as PooledObjects and Collections).