More classification perf fixes. #73535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 17, 2024
src/Workspaces/CSharp/Portable/Classification/SyntaxClassification/NameSyntaxClassifier.cs
Outdated
Show resolved
Hide resolved
…tion/NameSyntaxClassifier.cs
…i/roslyn into classificationExt2
CyrusNajmabadi
commented
May 17, 2024
| typeof(IdentifierNameSyntax), | ||
| typeof(QualifiedNameSyntax), | ||
| typeof(SimpleNameSyntax), | ||
| typeof(GenericNameSyntax), |
There was a problem hiding this comment.
no need to check these other 'composed name types'. We only care about X and X<...> (and we only classifiy the 'X' part of each). Every other name type composes into one of these two name types that we actually classify here.
this addresses a lot of callbacks for dotted names that serve no purpose.
CyrusNajmabadi
commented
May 17, 2024
| ]; | ||
|
|
||
| protected override int? GetRightmostNameArity(SyntaxNode node) |
CyrusNajmabadi
commented
May 17, 2024
src/Workspaces/CSharp/Portable/Classification/SyntaxClassification/NameSyntaxClassifier.cs
Outdated
Show resolved
Hide resolved
…tion/NameSyntaxClassifier.cs
|
@ToddGrun tiny mop up. ONe moer PR coming. Will not be doing obsolete-classification when doing FAR. It is nearly 7% of the scenario:
|
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span change is to address this:
Have commented the rest.