Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized string needed for workloads/wasm-experimental/description #76968

Closed
danroth27 opened this issue Aug 3, 2022 · 8 comments · Fixed by #102367
Closed

Localized string needed for workloads/wasm-experimental/description #76968

danroth27 opened this issue Aug 3, 2022 · 8 comments · Fixed by #102367
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@danroth27
Copy link
Member

danroth27 commented Aug 3, 2022

Looks like the new wasm-experimental workload is currently missing a description:

image

7.0.100-preview.7.22370.3

@lewing

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 3, 2022
@radical radical added the arch-wasm WebAssembly architecture label Aug 4, 2022
@ghost
Copy link

ghost commented Aug 4, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Looks like the new wasm-experimental workload is currently missing a description:

image

7.0.100-preview.7.22370.3

@lewing

Author: danroth27
Assignees: -
Labels:

arch-wasm, untriaged, area-VM-meta-mono

Milestone: -

@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 4, 2022
@radical
Copy link
Member

radical commented Aug 5, 2022

.NET WebAssembly experimental features - non-blazor templates, and multi-threading support? too long?

@radical radical self-assigned this Aug 9, 2022
@radical radical transferred this issue from dotnet/runtime Aug 9, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 9, 2022
@radical radical removed untriaged New issue has not been triaged by the area owner arch-wasm WebAssembly architecture area-VM-meta-mono labels Aug 9, 2022
@radical radical changed the title Provide a description for the wasm-experimental workload Localized string needed for workloads/wasm-experimental/description Aug 9, 2022
@radical radical removed their assignment Aug 9, 2022
@marcpopMSFT marcpopMSFT transferred this issue from dotnet/sdk Oct 12, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 12, 2022
@marcpopMSFT
Copy link
Member

@lewing can decide if this workload needs to have a description as I don't think anyone is supposed to install it.

@radical radical added the arch-wasm WebAssembly architecture label Oct 19, 2022
@ghost
Copy link

ghost commented Oct 19, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Looks like the new wasm-experimental workload is currently missing a description:

image

7.0.100-preview.7.22370.3

@lewing

Author: danroth27
Assignees: -
Labels:

arch-wasm, untriaged, area-VM-meta-mono

Milestone: -

@marek-safar marek-safar added this to the 8.0.0 milestone Jul 21, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 21, 2023
@marek-safar marek-safar added untriaged New issue has not been triaged by the area owner area-Build-mono and removed area-VM-meta-mono labels Jul 21, 2023
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jul 24, 2023
@lewing lewing modified the milestones: 8.0.0, 9.0.0 May 16, 2024
@lewing lewing removed their assignment May 16, 2024
@ilonatommy
Copy link
Member

current status:

Workload ID                 Description                                     
----------------------------------------------------------------------------
wasm-experimental           workloads/wasm-experimental/description         
wasm-experimental-net7      .NET WebAssembly experimental tooling for net7.0
wasm-experimental-net8      .NET WebAssembly experimental tooling for net8.0
wasm-tools                  .NET WebAssembly build tools                    
wasm-tools-net6             .NET WebAssembly build tools for net6.0         
wasm-tools-net7             .NET WebAssembly build tools for net7.0         
wasm-tools-net8             .NET WebAssembly build tools for net8.0 

#83223 was trying to fix it but used workloads/wasm-tools-experimental/description instead of workloads/wasm-experimental/description.

@ilonatommy
Copy link
Member

@lewing, we have the wasm-experimental description for English only and your PR added it only for that language. Shouldn't we have it for all the languages listed in src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/localize? workloads/wasm-tools/description has them translated.
Same story with workloads/runtimes-windows/description - only English.

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants