Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description discovery for wasm-experimental workload #102367

Merged
merged 7 commits into from
May 21, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented May 17, 2024

Fixes #76968.

Without this PR:
image

With this PR:
image

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels May 17, 2024
@ilonatommy ilonatommy self-assigned this May 17, 2024
@ilonatommy
Copy link
Member Author

I am adding full translations, in case @lewing you are against, we can revert the next commit.

@maraf
Copy link
Member

maraf commented May 17, 2024

Does it fix the similar issue in VS? #93314

@ilonatommy
Copy link
Member Author

ilonatommy commented May 20, 2024

Does it fix the similar issue in VS? #93314

It does not. VS's strings are held in:

<_ComponentResources Include="wasm-tools" Title=".NET WebAssembly Build Tools"

In the current-version _ComponentResources all the strings are missing the version number.
They are separate issues.

@ilonatommy ilonatommy merged commit cbe4d84 into dotnet:main May 21, 2024
23 checks passed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localized string needed for workloads/wasm-experimental/description
4 participants