-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fedora and Ubuntu CI legs to latest #40933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I factored out all distro versions into variables with versionless names. Next time, we should only have to update one file. We still have an outstanding issue regarding the artifacts rids and the prep script but I am declaring that beyond the scope of this PR (tracked with dotnet/source-build#4301). |
@ellahathaway - Because of the state of the SDK Diff pipeline, I was only able to validate the yml syntax was correct. Is that sufficient or is there a simple way to run the pipeline on main? |
Test build - https://dev.azure.com/dnceng/internal/_build/results?buildId=2453928&view=results (internal Microsoft link) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the state of the SDK Diff pipeline, I was only able to validate the yml syntax was correct. Is that sufficient or is there a simple way to run the pipeline on main?
Unfortunately, there isn't an easy way to do this. At one point, I had an Azdo branch with changes that allowed the pipeline to run against main, but it's currently out of date. If you think it'd be useful to have, I can update it. Otherwise, the changes you've made LGTM.
IMO we forge forward, if there is any fallout from this change we deal with it when the pipeline is re-enabled. |
Related to dotnet/source-build#4399 and dotnet/source-build#4301
Updated Fedora 39 to 40
Update Ubuntu 22.04 to Ubuntu 24.04