Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fedora and Ubuntu CI legs to latest #40933

Merged
merged 6 commits into from
May 17, 2024

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented May 16, 2024

Related to dotnet/source-build#4399 and dotnet/source-build#4301

Updated Fedora 39 to 40
Update Ubuntu 22.04 to Ubuntu 24.04

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels May 16, 2024
@MichaelSimons MichaelSimons marked this pull request as ready for review May 16, 2024 23:22
@MichaelSimons MichaelSimons requested review from a team as code owners May 16, 2024 23:22
Copy link
Member

@ellahathaway ellahathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build leg names here, here, and here will also need to be updated.

@MichaelSimons
Copy link
Member Author

The build leg names here, here, and here will also need to be updated.

I factored out all distro versions into variables with versionless names. Next time, we should only have to update one file. We still have an outstanding issue regarding the artifacts rids and the prep script but I am declaring that beyond the scope of this PR (tracked with dotnet/source-build#4301).

@MichaelSimons MichaelSimons marked this pull request as draft May 17, 2024 15:10
@MichaelSimons MichaelSimons marked this pull request as ready for review May 17, 2024 15:22
@MichaelSimons
Copy link
Member Author

@ellahathaway - Because of the state of the SDK Diff pipeline, I was only able to validate the yml syntax was correct. Is that sufficient or is there a simple way to run the pipeline on main?

@MichaelSimons
Copy link
Member Author

Test build - https://dev.azure.com/dnceng/internal/_build/results?buildId=2453928&view=results (internal Microsoft link)

Copy link
Member

@ellahathaway ellahathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the state of the SDK Diff pipeline, I was only able to validate the yml syntax was correct. Is that sufficient or is there a simple way to run the pipeline on main?

Unfortunately, there isn't an easy way to do this. At one point, I had an Azdo branch with changes that allowed the pipeline to run against main, but it's currently out of date. If you think it'd be useful to have, I can update it. Otherwise, the changes you've made LGTM.

@MichaelSimons
Copy link
Member Author

Because of the state of the SDK Diff pipeline, I was only able to validate the yml syntax was correct. Is that sufficient or is there a simple way to run the pipeline on main?

Unfortunately, there isn't an easy way to do this. At one point, I had an Azdo branch with changes that allowed the pipeline to run against main, but it's currently out of date. If you think it'd be useful to have, I can update it. Otherwise, the changes you've made LGTM.

IMO we forge forward, if there is any fallout from this change we deal with it when the pipeline is re-enabled.

@MichaelSimons MichaelSimons merged commit 6570e8b into dotnet:main May 17, 2024
24 checks passed
@MichaelSimons MichaelSimons deleted the 9.0-SB-CI branch May 17, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants