fix: make BullMQ server flags clearer #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Niennienzz
commented
Mar 8, 2024
Niennienzz
commented
- To address [Bug]: Dragonfly wont add children jobs taskforcesh/bullmq#2440
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chakaz
reviewed
Mar 9, 2024
docs/integrations/bullmq.md
Outdated
| @@ -14,22 +14,24 @@ By replacing Redis with Dragonfly, you can achieve superior performance and scal | |||
|
|
|||
| ## Running BullMQ with Dragonfly | |||
There was a problem hiding this comment.
I would even add a ## TL;DR section above this one, saying something like: if you can set add hash-tags to your queue name or prefix (e.g. {queue1} instead of queue1), use ./dragonfly ...
wdyt?
chakaz
reviewed
Mar 11, 2024
docs/integrations/bullmq.md
Outdated
| ## TL;DR | ||
|
|
||
| If you can use [hashtags](https://redis.io/docs/reference/cluster-spec/#hash-tags) in your queue names or prefixes (e.g., use `{queue1}` instead of `queue1`), | ||
| execute the following command to run Dragonfly. This will enhance the performance of your BullMQ workloads. |
There was a problem hiding this comment.
Suggested change
| execute the following command to run Dragonfly. This will enhance the performance of your BullMQ workloads. | |
| add the following flags. This will enhance the performance of your BullMQ workloads. |
Does this clarify that other flags can be used as well?
chakaz
approved these changes
Mar 11, 2024
No problem at all! I thought we're not done yet, so I changed a bit more. Please let me know if you like the newest version better! |
chakaz
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.