Add support for "limit 0"

drizzle-team · May 4, 2024 · 392d4e9 · 392d4e9
1 parent a78eefe
commit 392d4e9
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 6 deletions.
diff --git a/drizzle-orm/src/mysql-core/dialect.ts b/drizzle-orm/src/mysql-core/dialect.ts
@@ -323,7 +323,10 @@ export class MySqlDialect {
 			groupBySql = sql` group by ${sql.join(groupBy, sql`, `)}`;
 		}
 
-		const limitSql = limit ? sql` limit ${limit}` : undefined;
+		const limitSql = 
+			typeof limit === "object" || (typeof limit === "number" && limit >= 0) 
+			? sql` limit ${limit}` 
+			: undefined;
 
 		const offsetSql = offset ? sql` offset ${offset}` : undefined;
 
@@ -400,7 +403,10 @@ export class MySqlDialect {
 			orderBySql = sql` order by ${sql.join(orderByValues, sql`, `)} `;
 		}
 
-		const limitSql = limit ? sql` limit ${limit}` : undefined;
+		const limitSql = 
+			typeof limit === "object" || (typeof limit === "number" && limit >= 0) 
+			? sql` limit ${limit}` 
+			: undefined;
 
 		const operatorChunk = sql.raw(`${type} ${isAll ? 'all ' : ''}`);
 

diff --git a/drizzle-orm/src/pg-core/dialect.ts b/drizzle-orm/src/pg-core/dialect.ts
@@ -357,7 +357,10 @@ export class PgDialect {
 			groupBySql = sql` group by ${sql.join(groupBy, sql`, `)}`;
 		}
 
-		const limitSql = limit ? sql` limit ${limit}` : undefined;
+		const limitSql = 
+			typeof limit === "object" || (typeof limit === "number" && limit >= 0) 
+			? sql` limit ${limit}` 
+			: undefined;
 
 		const offsetSql = offset ? sql` offset ${offset}` : undefined;
 
@@ -443,7 +446,10 @@ export class PgDialect {
 			orderBySql = sql` order by ${sql.join(orderByValues, sql`, `)} `;
 		}
 
-		const limitSql = limit ? sql` limit ${limit}` : undefined;
+		const limitSql = 
+			typeof limit === "object" || (typeof limit === "number" && limit >= 0) 
+			? sql` limit ${limit}` 
+			: undefined;
 
 		const operatorChunk = sql.raw(`${type} ${isAll ? 'all ' : ''}`);
 

diff --git a/drizzle-orm/src/sqlite-core/dialect.ts b/drizzle-orm/src/sqlite-core/dialect.ts
@@ -295,7 +295,10 @@ export abstract class SQLiteDialect {
 
 		const orderBySql = orderByList.length > 0 ? sql` order by ${sql.join(orderByList)}` : undefined;
 
-		const limitSql = limit ? sql` limit ${limit}` : undefined;
+		const limitSql = 
+			typeof limit === "object" || (typeof limit === "number" && limit >= 0) 
+			? sql` limit ${limit}` 
+			: undefined;
 
 		const offsetSql = offset ? sql` offset ${offset}` : undefined;
 
@@ -362,7 +365,10 @@ export abstract class SQLiteDialect {
 			orderBySql = sql` order by ${sql.join(orderByValues, sql`, `)}`;
 		}
 
-		const limitSql = limit ? sql` limit ${limit}` : undefined;
+		const limitSql = 
+			typeof limit === "object" || (typeof limit === "number" && limit >= 0) 
+			? sql` limit ${limit}` 
+			: undefined;
 
 		const operatorChunk = sql.raw(`${type} ${isAll ? 'all ' : ''}`);