[Pg] Fix Zod Schema Generation for Array Items #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reordered ternary conditions in GetZodType in src/index.ts. Added array varchars to pg.test.ts
nenya1840
approved these changes
Feb 17, 2024
|
Excited for this to land! @nenya1840 is there something else needed before this gets merged into main? |
I don't have the write access |
|
Ah gotcha, maybe @AndriiSherman could help us? |
morganbarrett
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure, but I think this may solve #1609 and #1110
It seems like the bug might only be affecting the type inference and isn't a runtime bug. In a personal project I was able to remove the error by using
// @ts-ignoreto silence the warning, and it seemed to work normally.In
src/index.ts, this line is inferred astruefor some reason:Equal<TColumn['enumValues'], [string, ...string[]]> extends true, so this could also be due to some other unrelated upstream issue. I fixed this by moving the type checkTDataType extends 'array'check to be further up in the chain.