Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1152 - fire the operation events before after retrieving a query result even if it is cached #1153

Open
wants to merge 5 commits into
base: 8.x-4.x
Choose a base branch
from

Conversation

hchonov
Copy link

@hchonov hchonov commented Jan 30, 2021

Closes #1152

@Kingdutch
Copy link
Contributor

It'd be useful if we could distinguish in the event between a cached execution and an uncached execution. Either that or to have separate events for the two.

This is especially useful if you want to do performance measurements since a cached query will behave differently from an uncached query.

@klausi klausi added the 4.x label Feb 16, 2021
@hchonov hchonov changed the base branch from 8.x-4.x to 8.x-3.x June 30, 2021 16:55
@hchonov hchonov changed the base branch from 8.x-3.x to 8.x-4.x June 30, 2021 16:55
@dbosen
Copy link
Contributor

dbosen commented Nov 17, 2021

This completely fixes my language negotiation problems as well. The approach seems to be valid. +1 for merging this!

@dbosen
Copy link
Contributor

dbosen commented Dec 1, 2021

@hchonov and @Kingdutch It would be very nice if we could get this in the next release!

@hchonov
Copy link
Author

hchonov commented Dec 1, 2021

@dbosen I think that we could go with the current solution and add a $cachedExecution property to the OperationEvent to satisfy the request from @Kingdutch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The GraphQL language negotiation method is unusable with caching turned on
4 participants