Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apppears #906

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Apppears #906

wants to merge 15 commits into from

Conversation

eculler
Copy link
Contributor

@eculler eculler commented Sep 1, 2023

Addressing #905 Support APPEEARS Downloads

Description

This PR provides an AppeearsDownloader class. Users can instantiate the class with information about the dataset, time period, and spatial extent. The Downloader can then be triggered to download (or continue an incomplete download).

The AppeearsDownloader does not expose every feature of the API, but provides enough to be usable. Notably, spatial extent must be specified by GeoDataFrame, not bounding box or point location coordinates.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

  • A pytest test has been written, which downloads some Landsat data. This requires the use of the system keyring, and so this test will not run on GitHub Actions yet, but it can be run elsewhere. To test caching, make sure to stop the download before it is complete and re-start.

Checklist:

  • I have already submitted an issue and it was approved for a pr by an earthpy maintainer
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@eculler
Copy link
Contributor Author

eculler commented Oct 2, 2023

@nkorinek So, I used the keyring library to store Earthdata passwords, but honestly this is causing some problems since I can't figure out what the current version of the gnome keyring even is, much less get it installed on Codesaces. So I'm wondering if we can at least give the option to use a plain text configuration file. We could set it up to populate from GitHub secrets for Codespace users? If there's no config file, users will get prompted by input(), which is the current no-keyring behavior (but seems to get tripped up by ad blockers and popup blockers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant