Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Directus #397

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

berksmbl
Copy link
Contributor

@berksmbl berksmbl commented Jul 9, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for easypanel-templates ready!

Name Link
🔨 Latest commit 9be3e77
🔍 Latest deploy log https://app.netlify.com/sites/easypanel-templates/deploys/64cf58c0748ad900089f1977
😎 Deploy Preview https://deploy-preview-397--easypanel-templates.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ivanciucdragos1 ivanciucdragos1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

services.push({
type: "mysql",
type: input.databaseType,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

databaseType could be PostGIS, but we don't have service type for that. Am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in line 64, if these values come in, it redirects to a different place to create the database as an app.

command:
input.databaseType === "postgis"
? ""
: "docker-entrypoint.sh --default-authentication-plugin=mysql_native_password",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

db commands will be added soon, and this will be possible with native mysql service

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, let's hold the update or I can release 1 more update at that time. The decision is yours. @deiucanta

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deiucanta I have released the update about the new feature.

@matbrgz
Copy link

matbrgz commented Sep 21, 2023

This PR closes the issue #443.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants