-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Directus #397
base: main
Are you sure you want to change the base?
update: Directus #397
Conversation
✅ Deploy Preview for easypanel-templates ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
services.push({ | ||
type: "mysql", | ||
type: input.databaseType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
databaseType
could be PostGIS, but we don't have service type for that. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in line 64, if these values come in, it redirects to a different place to create the database as an app.
templates/directus/index.ts
Outdated
command: | ||
input.databaseType === "postgis" | ||
? "" | ||
: "docker-entrypoint.sh --default-authentication-plugin=mysql_native_password", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
db commands will be added soon, and this will be possible with native mysql service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want, let's hold the update or I can release 1 more update at that time. The decision is yours. @deiucanta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deiucanta I have released the update about the new feature.
This PR closes the issue #443. |
No description provided.