Add plane template #501
Open
Add plane template #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for easypanel-templates ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Mar 10, 2024
Draft
|
@deiucanta This has been updated to use the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This templates allows to setup Plane v0.16-dev.
Utilities Addition
In this PR (commit 4c7cac0), I also updated the
randomPasswordutility method, to support a optionallengthparameter, to generate longer passwords.Why customize
This template uses file mounts to overwrite some logic in the proxy service.
/etc/nginx/nginx.conf.custom: This is because the default nginx configuration inmakeplane/proxyuses other internal host names (such asapi,web,spaceandminio) rather than the full hostnames supported by EasyPanel (such asPROJECTNAME_api,PROJECTNAME_web,PROJECTNAME_spaceandPROJECTNAME_minio)./custom-docker-entrypoint.sh: This is used to apply the custom nginx configuration above.Template Issues
These was all resolved in 2ecaedb, applying the new
EASYPANEL_HOSTvariable available in EasyPanel v1.13.5.We are using the$(EASYPANEL_DOMAIN)option to automatically generate the domain names for theproxyandminioservices. However, since this variable includes the service name, it applies the wrong domain names below:Theproxyservice domain name, should ideally bePROJECTNAME.INSTANCE.easypanel.host, and notPROJECTNAME-proxy.INSTANCE.easypanel.host.TheWEB_URLenvironment inapi,beat-workerandworkerservice should match the above domain name. Right now it applies the service name (api,beat-workerandworker) to it.The domain names for theminioservice, should ideally be something like one of the following options:-PROJECTNAME-minio.INSTANCE.easypanel.io + PROJECTNAME-minio-console.INSTANCE.easypanel.io-PROJECTNAME-minio.INSTANCE.easypanel.io + console.PROJECTNAME-minio.INSTANCE.easypanel.ioTheAWS_S3_ENDPOINT_URLenvironment inapi,beat-workerandworkerservice should match the above domain name. Right now it applies the service name (api,beat-workerandworker) to it.Optimizations
api,beat-workerandworkerable to connect to theminioservice using the internal hostname, therefor a domain for theminioservice API is required, while it would be safer to use a internal endpoint for this.makeplane/proxysupported setting the hostnames by environment variables, then we can remove the custom nginx configuration and the custom entrypoint.But this will do for now.