add config support for TCP Bridges #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Andreas. Thanks - you need to fix the IP checks before I could merge this: "The pull request did not pass Eclipse validation. The following users do not have valid ECAs: The following users have invalid Signed-off-by footers: It's the Eclipse way - for which there are good reasons. |
Signed-off-by: Andreas Martens <amartens@uk.ibm.com>
|
yeah, saw the failures, took me a while to figure out how to "solve" them.. Think it's all done now? |
|
Yep. All good now. |
Signed-off-by: Andreas Martens <amartens@uk.ibm.com>
Signed-off-by: Andreas Martens <amartens@uk.ibm.com>
Signed-off-by: Andreas Martens <amartens@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only barely tested, and not all the configuration settings will be applied by TCPBridges (e.g. the prefixes haven't been implemented and
indirection hasn't been implemented.