chore: make tests os agnostic

edmundhung · Apr 30, 2024 · 524e433 · 524e433
1 parent be32a14
commit 524e433
Show file tree

Hide file tree

Showing 7 changed files with 3,578 additions and 3,048 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -16,12 +16,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Setup node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 20
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v3
         with:
           version: 8
       - name: Download deps
@@ -35,15 +35,18 @@ jobs:
 
   e2e:
     name: E2E Tests
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Setup node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 20
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v3
         with:
           version: 8
       - name: Download deps
@@ -53,9 +56,9 @@ jobs:
       - name: Run tests
         run: pnpm exec playwright test
       - name: Upload test result
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         if: always()
         with:
-          name: test-results
+          name: test-results-${{ runner.os }}
           path: test-results/
           retention-days: 30
diff --git a/package.json b/package.json
@@ -20,7 +20,7 @@
 		"@conform-to/validitystate": "workspace:*",
 		"@conform-to/yup": "workspace:*",
 		"@conform-to/zod": "workspace:*",
-		"@playwright/test": "^1.40.1",
+		"@playwright/test": "^1.43.1",
 		"@remix-run/eslint-config": "^1.19.3",
 		"@remix-run/node": "^1.19.3",
 		"@types/node": "^20.10.4",