Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix playground build #615

Merged
merged 1 commit into from Apr 30, 2024
Merged

chore: fix playground build #615

merged 1 commit into from Apr 30, 2024

Conversation

lifeiscontent
Copy link
Contributor

@lifeiscontent lifeiscontent commented Apr 29, 2024 •
edited

@edmundhung I'm hoping this will fix the issues we're seeing in playwright

@lifeiscontent lifeiscontent force-pushed the chore/fix-playground-build branch 2 times, most recently from 662d934 to 14c8c7d Compare April 29, 2024 02:08
edmundhung
edmundhung previously approved these changes Apr 29, 2024
View reviewed changes
Copy link
Owner

@edmundhung edmundhung left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the CI issue should be already resolved with #614, but it's great to update the playground app anyway.

edmundhung
edmundhung approved these changes Apr 30, 2024
View reviewed changes
Copy link
Owner

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@edmundhung edmundhung merged commit a774b45 into edmundhung:main Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundhung edmundhung edmundhung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lifeiscontent @edmundhung