Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust sizing and color of new paella icons #1165

Merged
merged 1 commit into from
May 23, 2024

Conversation

owi92
Copy link
Member

@owi92 owi92 commented May 13, 2024

This makes the new play and spinner icons slightly smaller and thinner, and uses a darker grey.
Bildschirmfoto 2024-05-13 um 12 51 08

@github-actions github-actions bot temporarily deployed to test-deployment-pr1165 May 13, 2024 10:59 Destroyed
@owi92 owi92 mentioned this pull request May 13, 2024
@owi92 owi92 added the changelog:user User facing changes label May 13, 2024
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I like that the icon is smaller, but now it's also smaller for small screens. What about keeping the width: 20%, but add max-width: 150px? I like the sizes on all screen sizes then.

  • I like the thinner stroke width of the icon.

  • Regarding color and shadow: I think the previous version was better. Generally, we do need the shadow as otherwise, regardless of what color we chose, there will be a preview image that ruins everything. The blurred shadow is not quite the prettiest, but I think it looks alright. We can also reduce the blur radius to 1.5px or 1px and instead make the shadow color darker, e.g. black. Then it's sharper.

@oas777
Copy link
Collaborator

oas777 commented May 18, 2024

Just a reminder we wanted to test the new design with different videos: "I would suggest you take a look at a couple of videos with different backgrounds. I still think the lighter version works better for a variety of backgrounds, but if as you said the majority of videos will have a white background anyway, the darker version should be ok to use." (Ole)

@owi92
Copy link
Member Author

owi92 commented May 20, 2024

Ok so with sizing and stroke-width aka thickness out of the way, this comes down to dark vs light icons. While I said that dark icons should be ok to use, comparing both side by side with dark and light backgrounds, I do still think the light version works better.

Also keep in mind that light preview images tend to have dark/black text which doesn't work great in combination with a dark icon. Though I realize the same could be said vice versa for the light icon.
Unfortunately it's hard to find a one-size-fits-all solution, but I'd still advocate for the lighter icon, which also works works better with the spinner icon (that is always on a dark background).

As Lukas said, there will always be some preview image that won't look too good with either version. See the following for a comparison:
Bildschirmfoto 2024-05-20 um 23 41 04

As a footnote: These icons also need an outline so they'll be visible on backgrounds with the exact same color, and here a light icon with dark outline works better than a dark icon with a light outline. The latter tends to look like it's glowing on dark backgrounds. This effect can be seen in the dark icon/dark background combination of the above table.

@LukasKalbertodt
Copy link
Member

Thanks Ole for the comparison. My position remains the same as yours: I prefer the white icon.

@oas777
Copy link
Collaborator

oas777 commented May 21, 2024

Yes, white is the colour to work with.

@github-actions github-actions bot temporarily deployed to test-deployment-pr1165 May 21, 2024 11:39 Destroyed
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasKalbertodt LukasKalbertodt merged commit 51008d8 into elan-ev:master May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants