[ES|QL] Generate docs for unregistered esql functions from annotations #108749
Conversation
fang-xing-esql
added
>docs
|
Documentation preview: |
elasticsearchmachine
added
Team:Docs
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| @Override | ||
| public void testFactoryToString() { | ||
| assumeFalse("test case is invalid", false); | ||
| } |
There was a problem hiding this comment.
I wonder if we can pull out a superclass of AbstractFunctionTestCase without these methods.
There was a problem hiding this comment.
Discussed with Nik about this, skipping testFactoryToString is for InTest only, it is because the way In is implemented in ES|QL is different from the other functions, it doesn't implement EvaluatorMapper. Follow up PRs will be opened to rewrite In using EvaluatorMapper and clean up EvaMapper. This PR is mainly for doc generation through annotations, leave this test skipped for now, and when the In is rewritten with EvaluatorMapper, InTests will be modified.
|
|
||
| @Override | ||
| public void testSimpleWithNulls() { | ||
| assumeFalse("test case is invalid", false); |
There was a problem hiding this comment.
How many legitimate callers of this are there left? I imagine you've nearly replaced all users of this with anyNullIsNull and the like.
There was a problem hiding this comment.
Same as above, after rewriting In with EvaluatorMapper, the InTests will be modified accordingly, this is for doc generation only.
|
The docs don't quite look right: |
|
This is heroic work, btw. Thanks so much for it. |
I'll remove one of them. |
This is a subtask of #104247 , covers operators that are unregistered functions.