-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TransportSimulateShardBulkAction #108795
Open
masseyke
wants to merge
6
commits into
elastic:main
Choose a base branch
from
masseyke:adding-TransportSimulateShardBulkAction
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding TransportSimulateShardBulkAction #108795
masseyke
wants to merge
6
commits into
elastic:main
from
masseyke:adding-TransportSimulateShardBulkAction
+513
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
>non-issue
labels
May 21, 2024
elasticsearchmachine
added
the
Team:Data Management
Meta label for data/management team
label
May 21, 2024
Pinging @elastic/es-data-management (Team:Data Management) |
parkertimmins
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here, this is on my radar to get to but have not found the time yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
>non-issue
Team:Data Management
Meta label for data/management team
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a TransportSimulateShardBulkAction, meant to be used in simulate ingest in place of TransportShardBulkAction. This delegates virtually all of its logic to TransportShardBulkAction. However, TransportShardBulkAction is a WriteAction and TransportSimulateShardBulkAction is not -- TransportSimulateShardBulkAction does not change state in any way (cluster state, shards, or translog). Since it does not write to shards, it does not need to perform a refresh.
This PR does not actually wire TransportSimulateShardBulkAction up for use by the simulate ingest API (or anything else). See #106440 for the full draft where it is called by BulkOperation (which is called due to the changes in TransportSimulateBulkAction in that PR).
Relates to #108791