Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESS][Pt. Duex] Adding value list file size constraints to UI docs #5001

Merged
merged 10 commits into from
May 20, 2024
Merged

[ESS][Pt. Duex] Adding value list file size constraints to UI docs #5001

merged 10 commits into from
May 20, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Mar 27, 2024 •
edited

@nastasha-solomon nastasha-solomon added Feature: Exceptions Team: Detection Engine Priority: Medium Issues that have relevance, but aren't urgent Effort: Small Issues that can be resolved quickly labels Mar 27, 2024
@nastasha-solomon nastasha-solomon self-assigned this Mar 27, 2024
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link

mergify bot commented Mar 27, 2024

This pull request does not have a backport label. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@nastasha-solomon nastasha-solomon marked this pull request as ready for review April 2, 2024 18:50
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner April 2, 2024 18:50
joepeeples
joepeeples previously approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yctercero
yctercero previously approved these changes May 20, 2024
View reviewed changes
@nastasha-solomon nastasha-solomon merged commit 2e9f4b1 into main May 20, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request May 20, 2024
@nastasha-solomon @mergify
[ESS][Pt. Duex] Adding value list file size constraints to UI docs (#…
85a21c5 
…5001)

* First draft

* Input from Yara

* Update docs/detections/value-list-exceptions.asciidoc

* Update docs/detections/value-list-exceptions.asciidoc

* Remove duplicated content

(cherry picked from commit 2e9f4b1)
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
mergify bot pushed a commit that referenced this pull request May 20, 2024
@nastasha-solomon @mergify
[ESS][Pt. Duex] Adding value list file size constraints to UI docs (#…
04201f3 
…5001)

* First draft

* Input from Yara

* Update docs/detections/value-list-exceptions.asciidoc

* Update docs/detections/value-list-exceptions.asciidoc

* Remove duplicated content

(cherry picked from commit 2e9f4b1)
mergify bot pushed a commit that referenced this pull request May 20, 2024
@nastasha-solomon @mergify
[ESS][Pt. Duex] Adding value list file size constraints to UI docs (#…
dec3733 
…5001)

* First draft

* Input from Yara

* Update docs/detections/value-list-exceptions.asciidoc

* Update docs/detections/value-list-exceptions.asciidoc

* Remove duplicated content

(cherry picked from commit 2e9f4b1)
This was referenced May 20, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 20, 2024
@nastasha-solomon @mergify
[ESS][Pt. Duex] Adding value list file size constraints to UI docs (#…
bf770f2 
…5001)

* First draft

* Input from Yara

* Update docs/detections/value-list-exceptions.asciidoc

* Update docs/detections/value-list-exceptions.asciidoc

* Remove duplicated content

(cherry picked from commit 2e9f4b1)

# Conflicts:
#	docs/detections/value-list-exceptions.asciidoc
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
nastasha-solomon added a commit that referenced this pull request May 20, 2024
@mergify @nastasha-solomon
[8.13] [ESS][Pt. Duex] Adding value list file size constraints to UI …
e3e6aa6 
…docs (backport #5001) (#5249)

* First draft

* Input from Yara

* Update docs/detections/value-list-exceptions.asciidoc

* Update docs/detections/value-list-exceptions.asciidoc

* Remove duplicated content

(cherry picked from commit 2e9f4b1)

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request May 20, 2024
@mergify @nastasha-solomon
[8.12] [ESS][Pt. Duex] Adding value list file size constraints to UI …
50e4a39 
…docs (backport #5001) (#5250)

* First draft

* Input from Yara

* Update docs/detections/value-list-exceptions.asciidoc

* Update docs/detections/value-list-exceptions.asciidoc

* Remove duplicated content

(cherry picked from commit 2e9f4b1)

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request May 20, 2024
@mergify @nastasha-solomon
[8.14] [ESS][Pt. Duex] Adding value list file size constraints to UI …
7a1c99f 
…docs (backport #5001) (#5248)

* First draft

* Input from Yara

* Update docs/detections/value-list-exceptions.asciidoc

* Update docs/detections/value-list-exceptions.asciidoc

* Remove duplicated content

(cherry picked from commit 2e9f4b1)

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request May 29, 2024
@mergify @nastasha-solomon
[7.17] [ESS][Pt. Duex] Adding value list file size constraints to UI …
825016d 
…docs (backport #5001) (#5251)

* [ESS][Pt. Duex] Adding value list file size constraints to UI docs (#5001)

* First draft

* Input from Yara

* Update docs/detections/value-list-exceptions.asciidoc

* Update docs/detections/value-list-exceptions.asciidoc

* Remove duplicated content

(cherry picked from commit 2e9f4b1)

# Conflicts:
#	docs/detections/value-list-exceptions.asciidoc

* Fix

Removing page that shouldn't be in the 7.17 docs

* Revert "Fix"

This reverts commit 07139c7.

* Removing page

Removing page that shouldn't be added to 7.17 and updating 7.17 value list docs

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples approved these changes

@yctercero yctercero yctercero left review comments

Assignees

@nastasha-solomon nastasha-solomon

Labels
Effort: Small Issues that can be resolved quickly Feature: Exceptions Priority: Medium Issues that have relevance, but aren't urgent Team: Detection Engine v7.17.0 v8.12.0 v8.13.0 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nastasha-solomon @yctercero @joepeeples