-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security upgrade guide 7.17-8.x #5186
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @natasha-moore-elastic? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see this important page getting some love! Left some suggestions for your consideration, I hope they're helpful. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall!
I added a few comments - biggest one is that we need to add the meta framework around repeating the upgrade process for 1. PROD - if you did non-prod first. 2. Other clusters - if you have a CCS environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once my 3 comments are resolved, LGTM and I approve.
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e)
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e)
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e)
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e)
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e)
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
* Security upgrade guide 7.17-8.x * Replaces component names with attributes * Adds links * Fixes formatting * First round of slight edits. * Apply suggestions from code review Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Addresses feedback * Merging some feedback * Merging more feedback... * More feedback... * Adding some more feedback... * Typo fix * Adding in Mike's feedback * Two small nits. --------- Co-authored-by: Janeen Roberts <janeen.roberts@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit cdd1e6e) Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Resolves #3211.
Previews: