Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BrowserView autoresizing conversion error #42056

Merged
merged 1 commit into from May 13, 2024
Merged

fix: BrowserView autoresizing conversion error #42056

merged 1 commit into from May 13, 2024

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 7, 2024 •
edited

Description of Change

Closes #42003.

Fixes the following issue when setting autoResize on a BrowserView:

Screenshot 2024-05-06 at 9 16 39 PM

This was happening because setBounds accepts a gfx::Rect and we were trying to pass double values to the width and height when resizing.

Checklist

Release Notes

Notes: Fixes an error when calling setAutoResize on a BrowserView.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. labels May 7, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 7, 2024
@dsanders11 dsanders11 added target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. and removed target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. labels May 8, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 8, 2024
nornagon
nornagon reviewed May 8, 2024
View reviewed changes
lib/browser/api/browser-view.ts Outdated Show resolved Hide resolved
lib/browser/api/browser-window.ts Outdated Show resolved Hide resolved
jkleinsc
jkleinsc previously requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so that @nornagon's suggestions get implemented.

@codebytere codebytere dismissed jkleinsc’s stale review May 13, 2024 08:26

Requested changes were addressed and approved by original requester :)

@codebytere codebytere merged commit c765d57 into main May 13, 2024
17 checks passed
@codebytere codebytere deleted the fix-auto-resize branch May 13, 2024 08:27
@release-clerk Release Clerk
Copy link

release-clerk bot commented May 13, 2024

Release Notes Persisted

Fixes an error when calling setAutoResize on a BrowserView.

This was referenced May 13, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 13, 2024

I have automatically backported this PR to "30-x-y", please check out #42137

@trop trop bot added in-flight/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels May 13, 2024
@trop
Copy link
Contributor

trop bot commented May 13, 2024

I have automatically backported this PR to "31-x-y", please check out #42138

@trop trop bot added in-flight/31-x-y and removed target/31-x-y PR should also be added to the "31-x-y" branch. labels May 13, 2024
@cklim5
Copy link

cklim5 commented May 13, 2024

Description of Change

Closes #42003.

Fixes the following issue when setting autoResize on a BrowserView:

Screenshot 2024-05-06 at 9 16 39 PM

This was happening because setBounds accepts a gfx::Rect and we were trying to pass double values to the width and height when resizing.

Checklist

Release Notes

Notes: Fixes an error when calling setAutoResize on a BrowserView.

@trop trop bot added merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. and removed in-flight/30-x-y in-flight/31-x-y labels May 13, 2024
Mrnikifabio pushed a commit to Mrnikifabio/electron that referenced this pull request May 14, 2024
@codebytere @Mrnikifabio
fix: BrowserView autoresizing conversion error (electron#42056)
468ea10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Frameless BrowserView.setAutoResize() is broken in v30.0.1
5 participants
@codebytere @cklim5 @nornagon @jkleinsc @dsanders11