I don't know how to resole the lint error i m getting #1559
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can anyone help me with |
|
error on test:ci |
erickzhao
reviewed
Mar 12, 2024
src/renderer/components/output.tsx
Outdated
| this.editor.addCommand( | ||
| MonacoType.KeyMod.CtrlCmd | MonacoType.KeyCode.KEY_K, | ||
| () => { | ||
| if (this.model) this.model.setValue('Console Cleared !'); |
There was a problem hiding this comment.
I don't think I'd want a message when clearing the console. 😅
There was a problem hiding this comment.
is that mean i m doing right ?
or i m doing something else which is not actually required ?
what if i do if (this.model) this.model.setValue("");
There was a problem hiding this comment.
and i did use this this.model.setValue('Console Cleared !'); because i use CTRL+L orCTRL+SHIFT+L
it will move the cursor to the top of the terminal window and clear all the text that was previously displayed.
However, it doesn't erase the command history; you can still scroll up to see previous commands and output.
diivi
reviewed
Mar 21, 2024
Co-authored-by: Divyansh Singh <divyanshanandsingh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error was in contribution.json ?
lint error
previous pull
changes i did