feat: ensure Fiddle on macOS updates through v0.35.1 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
approved these changes
Dec 7, 2023
src/updates.js
Outdated
| if ( | ||
| [PLATFORM_ARCH.DARWIN_X64, PLATFORM_ARCH.DARWIN_ARM64].includes(platform) && | ||
| account === "electron" && | ||
| repository === "fiddle" && |
There was a problem hiding this comment.
Normally not worth the squeeze, but given the "requests per second" this service handles, you might want to make the simple account check before checking for array inclusion. Then again, V8 might do that for us.
There was a problem hiding this comment.
Good point! I reordered them, and made the version check the second condition since that should lead to the fewest number of comparisons (assuming they're actually done in this order, as you said) by bailing out early once the majority of clients have updated past v0.35.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we switch Fiddle to code signing with certificates from OpenJS, we need to ensure all users on macOS go through version v0.35.1 before updating further since it includes a requirement which allows for the OpenJS team ID to be used to sign Fiddle releases.