Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use electronjs/node orb #156

Merged
merged 1 commit into from
Apr 15, 2024
Merged

ci: use electronjs/node orb #156

merged 1 commit into from
Apr 15, 2024

Conversation

dsanders11
Copy link
Member

Greatly simplifies the config by using electronjs/node. IMO it's better to use electronjs/node here instead of pinning to a specific cimg/node since I don't know how long those tags receive security updates for, while electronjs/node installs Node.js on top of cimg/base.

@dsanders11 dsanders11 marked this pull request as ready for review April 10, 2024 20:31
@dsanders11 dsanders11 requested a review from a team as a code owner April 10, 2024 20:31
@juliangruber
Copy link
Contributor

Is it time to switch to GitHub Actions, for simplicity?

@dsanders11 dsanders11 merged commit edc043d into main Apr 15, 2024
3 checks passed
@dsanders11 dsanders11 deleted the ci/node-orb branch April 15, 2024 08:55
@dsanders11
Copy link
Member Author

Is it time to switch to GitHub Actions, for simplicity?

In this specific case not sure we gain much from switching it just because we use CircleCI (and the electronjs/node orb) across the rest of our Ecosystem WG repos (since many of them need CircleCI for our CFA implementation), so it's nice to be consistent. But yes, this would be straightforward to switch to GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants