Keygen cleanup #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have the full context here, but it looks like maybe a seed option was intended to go here (like https://github.com/mafintosh/hypercore-crypto/blob/ccb36609c100afe4eadb6bc4a92b3656f9548096/index.js#L12-L23 ?), but also the option to pass your own keypair buffers. Since there is already a seedKeygen function, and the seed path doesn't work here, the best thing to do appears to remove it.
I don't have full context here, but this change looks more correct. If it isn't maybe a comment explaining why is warranted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a few minor issues regarding the keygen methods. This should help clean those up if my understanding is correct.