Add a conditional replace explanation #336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from well defined changes, resources may be also conditionally replaced. This should be annotated in the proposed changes. Also change the colour to red for potential replacements.
|
Warnings: No tests. I'm not sure how to test this and I sank enough time flailing around. Ideas welcome. |
|
What about reusing the AWS terms here? Using |
jacobbednarz
approved these changes
Jun 2, 2020
lib/stack_master/change_set.rb
Outdated
| @@ -101,7 +106,7 @@ def action_color(action_name) | |||
| :green | |||
| when 'Modify' | |||
| :yellow | |||
| when 'Remove', 'Replace' | |||
| when 'Remove', 'Replace', 'Maybe replace' | |||
There was a problem hiding this comment.
Does this need to be Conditional replace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from well defined changes, resources may be also conditionally replaced.
This should be annotated in the proposed changes.
Also change the colour to red for potential replacements.