Fixed scoped class on modal #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ksem
approved these changes
May 23, 2024
Fsss126
added a commit
that referenced
this pull request
May 25, 2024
* fix: tab animation when link * fix(tabs): what for router link changes * feat(data-table): add no-data slot * fix(counter/#4281): disable button in readonly VaCounter * fix(file-upload/#4282): add file incorrect i18n key * Fixed scoped class on modal (#4274) * Try to resolve $t from vue global properties (#4244) (#4256) * Try to resolve $t from vue global properties #4244 * fix(docs/i18n): move back vuestic key in example * docs(i18n): remove extra steps in vue-i18n --------- Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com> * Let VaDateInput accept a null value (#4169) * Allow a user to have a null date input. Devs will have to handle validation as they normal would with other controlls. * Updated to use props.clearValue and merged develop back in * fix(date-input): allow null value --------- Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com> * fix(i18n): use custom values when translating props * fix(data-table/story): fix correct no filter data story * Fixed code audit modal on mobile --------- Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com> Co-authored-by: Bond-Addict <117455332+Bond-Addict@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The modal element is assigned data-v-data-v-[hash] attribute so that scoped classes are not applied which is a bug
Types of changes