"*.re"（Re:VIEW形式のファイル名）を部構成のキーに指定できるようにした #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
すみません。#4 の実装に見落としがあり、部構成のキーに.mdのファイル名は受け付けるようになっていましたが、.reのファイル名を受け付けない状態になってしまっておりました。
コピーするファイル名が配列の各要素固定でなくなってしまったため、copy()を削除してfiles.exportFileToDisk()を直接呼ぶようにしましたが、copy()に引数としてファイル名を指定できるようにする方が正道でしょうか？
ご意見を頂けましたら幸いです。