Npm updates #21
Open
Npm updates #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Constellation @michaelficarra Would it be possible to get some review / comments on this? I just noticed that ESLint is requiring different versions of estraverse because estools/esquery has been updated, but esrecurse hasn't. |
|
Btw, I updated the devDeps. further and got to 100% coverage. |
- License: Add separate copy of BSD-2-Clause (as per other estools project) - Travis: Change from stable to 10, 12, 14 - Linting: Apply config used in other estools projects (disabling in main file until Babel routine to be added to build) - Docs (README): Use more current syntax in examples - Refactoring: Remove gulp in favor of npm scripts - Babel: Use "json" extension - npm: Add npmrc as per other estools projects - npm: Use `files` in package.json in place of `.npmignore` (as per other estools projects) - npm (package.json): Add recommended bugs and keywords fields and use author/contributors in place of maintainers - npm: Update to Babel 7/preset-env; update other devDeps. (chai, esprima) - npm: Remove unneeded babel-eslint and unused jsdoc - Testing: Use chai/register-expect and babel/register - Testing: Add coverage with nyc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filesin package.json in place of.npmignore(as per other estools projects)Note that I've set nyc thresholds below 100% since there are still a few uncovered lines. I wasn't sure whether esrecurse should be allowing for poorly formed AST, and it seems that the remaining cases may not be reachable for invalid AST.I went ahead and added tests to fully cover current code expectations. If validation is ever desired to reject AST without normally expected properties liketype, the tests can be changed.I could submit an ESM PR though I'll await results of the discussion of estools/esutils#34 (comment) .