Support TLS for BYOR #207
Open
Support TLS for BYOR #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now TLS-protected Docker-daemons are supported: users can attach corresponding certificates when filling the form.
Technical note: the creation of a Docker-client in the case of BYOR should be done asynchronously since that's a pure network-operation. However, the method "load_state" must not be a Tornado-coroutine, so an attempt to restore the BYOR-Docker-client is done in a synchronous way. Taking into account the fact of rare usage of BYOR and that this synchronous call is done only when Everware itself starts, it's unlikely to cause any problems.