Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linking to local files #123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lorefnon
Copy link

Resolves #122

@pomdtr
Copy link
Collaborator

pomdtr commented Feb 21, 2024

Thanks for your contribution.

I think we can improve this a bit:

Here a url or type: https://raw.githubusercontent.com/.../example
excalidraw would not be handled properly.

Instead of relying on the file extension, maybe we can just open any url without scheme in vscode:

Ex: ./test.excalidraw or /tmp/readme.md

@lorefnon
Copy link
Author

lorefnon commented Feb 21, 2024

Instead of relying on the file extension, maybe we can just open any url without scheme in vscode:

This is what I originally did. However it opens excalidraw files as json. So I added special handling for .excalidraw extension. References to non excalidraw files do work.

I'll update this so absolute paths will be handled correctly. The Url handling can stay as it currently is, yes ?

@pomdtr
Copy link
Collaborator

pomdtr commented Feb 21, 2024

I see, then it make sense. I'll play a bit with your branch locally to see if the linking behavior match my expectations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for local links
2 participants