fix: FileSave now respects file extensions in windows #7860
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This was referenced Apr 6, 2024
unpervertedkid
changed the title
unpervertedkid
changed the title
|
@ryan-di do i need more approvals for the pending checks to be run? |
running now, apologize for the delay! |
No worries, all good now... |
|
@ryan-di I belive we can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue where the
fileSavefunction in the browser-fs-access library does not respect theextensionsoption. This issue has been previously noted in #113 . This caused issues with saving file after renaming where a user would expect it to retain the correct extension but did not as shown in the before video below.The issue has also been noted in issue #7762
Note
Fix
The fix involves adding
mimeTypesto thefileSavefunction, which ensures that the correct file type is suggested in the save dialog.Comparison
Before.mp4
After.mp4