-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Introduce font picker #8012
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Hi @Mrazator 👋🏻 |
4c8197f
to
9e660d1
Compare
Prepare trigger for the picker button, better styles Introduce popup menu, search, font list, basic styles Renamed divider into separator Introduced shared primitives for quick search, scrollable list, properties popover, etc.; unified existing components to be composed of these primitives Added font badge, nicer styles for darkmode Adding Virgil 2, cleaning duplicated fonts, preloading default fonts, fixing issue with fonts being requested multiple times Keyboard navigation, other small improvements
9e660d1
to
0003544
Compare
@ad1992 All valid questions, but for now there are no clear answers. We might end up releasing only the improved Virgil for better readability while leaving the picker with a few chosen fonts (WIP for now) for E+ only. Supporting other fonts atm is questionable, as from the multiple perspectives it's not as straightforward as it looks like, hence we would like to nail that part first. |
…focused search, removed icons, fixing related bugs
packages/excalidraw/fonts.ts
Outdated
|
||
// base urls will be applied for relative `uri`'s only | ||
// TODO: should be loaded from a CDN once we publish the package (and the env variables are correctly injected) | ||
this.url = new URL(uri, window.EXCALIDRAW_ASSET_PATH ?? window.origin); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than falling back to window.origin
and expecting the host apps to copy the assets, we might want to fall back to our public CDN. However, atm vite env variables do not seem to be injected at build time (needs to be fixed first) & neither is the package publishes, which ends up with unloaded fonts i.e. in the nextjs example. Also, we should consider a separate CDN for long-lived static assets, such as fonts.
03611ef
to
b8facf7
Compare
b8facf7
to
73cbbbc
Compare
…fixing asset loading issues in the app
82e46e9
to
0c4631f
Compare
TBD