[video][ios] Add base64 certificate support #28990
Open
+35
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: e1e519e Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-video/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "2633b5f5ccad5d6ecfb5dc457ce572381ed7db39"
}
]Generated by PR labeler 🤖 |
behenate
force-pushed
the
@behenate/video/add-base64-cert
branch
from
63b0db9
to
fc26303
Compare
expo-bot
added
bot: passed checks
aleqsio
approved these changes
May 22, 2024
tsapeta
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some of the users requested the feature of passing the certificate as base64 string instead of a server url.
How
Added an additional property in the
DRMOptionsto accept thebase64CertificateData, when provided it will override the `certificateUrl.Test Plan
Tested in BareExpo on a physical iOS device.