Interop between CAGRA and HNSW #3252
Conversation
|
@mdouze I addressed your first batch of reviews. Could you re-review when it is convenient for you? |
There was a problem hiding this comment.
What is the level of parity between GPU search and CPU search? The search function on CPU does not have access to the Cagra search parameters.
Could you write a few python tests taking inspiration from
https://github.com/facebookresearch/faiss/blob/main/faiss/gpu/test/test_contrib_gpu.py
I would like to see:
-
build and search on GPU
-
index_gpu_to_cpu on a Cagra graph
-
serialization / deserialization
-
search on CPU
Thanks!
| @@ -46,6 +46,8 @@ project(faiss | |||
| LANGUAGES ${FAISS_LANGUAGES}) | |||
| include(GNUInstallDirs) | |||
|
|
|||
| set(CMAKE_INSTALL_PREFIX "$ENV{CONDA_PREFIX}") | |||
There was a problem hiding this comment.
Not sure we want to keep this as Faiss is not necessarily compiled in a conda env.
There was a problem hiding this comment.
Ah, sorry. This was just for development purposes - I will remove it.
|
@mdouze thanks for your review! Btw, the C++ tests cover all the tests you mentioned except serialization. Nonetheless, I will definitely add python tests per your suggestion. |
|
@mdouze I seem to be unable to build faiss C++ tests after merging some recent commits into my branch. This is the error I get, can you help? I have tried deleting build/cache and building again: |
|
Hi @divyegala! Can you share the steps to reproduce the error? |
|
@Di-Is I figured out what the issue is. I build FAISS in a conda environment, and re-configuring FAISS CMake does not overwrite the FAISS header files that get copied the very first time when I configure FAISS CMake. As a consequence, any time there's changes to an API or new APIs are added, the header files in the conda environment become stale. |
|
@mdouze I have added Python tests, could you review when possible? |
|
Thanks! Importing to the internal repo. |
|
@mdouze has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Depends on #3084