Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace dependency picture with a hyperlink map #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jceb
Copy link

@jceb jceb commented Apr 27, 2021

I added the hyperlink map from sanctuary-type-classes as I find it much easier to navigate and consume than the two-fold link list + dependency picture.

@CrossEye
Copy link

This is a great improvement!

Note that there is a typo in the semigroupoid link.

@davidchambers
Copy link
Member

Several people raised concerns when I proposed this change in #160.

@jceb
Copy link
Author

jceb commented Apr 27, 2021

Hm, shall we include both, i.e. restore the list, restore the figure and place the pre-formatted map below?

@davidchambers
Copy link
Member

@joneshf was concerned about maintenance; perhaps he will chime in. Maintaining the graph in sanctuary-type-classes has not proven onerous. We have a script that automatically updates the readme as part of the release process, and the source is easy to edit in Vim or any other editor with a block mode. Furthermore, changes have not been necessary for several years.

I am in favour of the proposed change, but I think we should incorporate a modified version of the aforementioned script.

@joneshf
Copy link
Member

joneshf commented Jun 16, 2021

Sorry, I thought I'd responded to this.

I don't really have an opinion on this stuff these days. I say, do what makes sense to you all.

@davidchambers
Copy link
Member

I'm in favour of this change, @jceb. Is this pull request up to date? I see that it has been open for more than two years. 😭

@jceb
Copy link
Author

jceb commented Sep 23, 2023

Let me double check😀

@jceb jceb force-pushed the hyperlink-algebraic-structures branch from f03ea75 to 5a0cfb9 Compare September 24, 2023 08:18
@jceb
Copy link
Author

jceb commented Sep 24, 2023

I rebased the PR. It's now up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants