Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tap@18 #5471

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: update tap@18 #5471

wants to merge 3 commits into from

Conversation

climba03003
Copy link
Member

Checklist

@jsumners
Copy link
Member

Unless things have changed, it's a little bit more involved https://github.com/fastify/fastify/pull/4978/files

@climba03003
Copy link
Member Author

climba03003 commented May 17, 2024

Unless things have changed

Tested locally, it only requires minimal changes.
Is it hard requirement to remove c8?

@jsumners
Copy link
Member

tap@18 is using c8 itself.

@climba03003
Copy link
Member Author

climba03003 commented May 17, 2024

After testing on removing the external c8 and using the internal one.
It forced to includes the files that should be ignored in the coverage report.
For example, error-serializer.js.

@gurgunday
Copy link
Member

Are macos tests flaky?

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like only macOS fails with a heap limit error

@gurgunday
Copy link
Member

gurgunday commented May 26, 2024

Do you know why macOS unit test CI could be failing? @climba03003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants