Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show message under run time if delay has changed #688

Merged

Conversation

emko
Copy link
Contributor

@emko emko commented Feb 16, 2024

looking a the issue i see you guys don't want to support getting the real run at time from the redis sorted sets score value instead you want bullmq to add job.runAt field, can we at least have this ?

added *Delay changed; the new run time is currently unknown under run at if the initial delay does not equal the current delay as Bullmq does not return a timestamp for when the job will actually run, also i changed it to use the initial delay using the current delay will give you wrong run at time anyways.

image

@felixmosh
Copy link
Owner

Hi @emko thank you for the PR.
Can you elaborate on the issue this PR tries to solve? (example is prefered :] )

@emko
Copy link
Contributor Author

emko commented Feb 18, 2024

Hi @emko thank you for the PR. Can you elaborate on the issue this PR tries to solve? (example is prefered :] )

taskforcesh/bullmq#1728

Problem is if you ever change the delay on your job with changeDelay BullMq does not store the new timestamp on the Job, so there is no way on the UI to know when this job will run. This PR just indicates that the jobs delay has been changed, we have many users who complain that jobs are not running when they said they will and this would tell them why it won't

we just have to wait for bullMQ to add something like this
taskforcesh/bullmq#1732

but for now i think there should be a warning if the delay has been changed

@felixmosh
Copy link
Owner

Thank you for the explanation, I'll review that asap

@felixmosh felixmosh merged commit 133316f into felixmosh:master Mar 11, 2024
@felixmosh
Copy link
Owner

Thank you, released in v5.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants