-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch macos builds to apple silicon and upgrade xcode #424
Conversation
This is even more difficult. We currently create universal binaries on MacOS for x86 and aarch64. We need to check if it also works to create x86 version on the M1. I've opened #420 for tracking that. |
c94a83e
to
21779e7
Compare
I've fixed the original error, it was just about setting the |
This PR needs thorough review/testing by someone from the Lotus team. It should build the correct release artifacts, but I haven't really tested it. I'm neither that familiar with Lotus, nor do I own a Mac. |
It's now possible to build universal binaries on x86_64 as well as aarch64. Closes #420.
a9700e7
to
1b54ec8
Compare
@galargh @vmx I hope you don't mind that I rebased and force pushed this branch to get it updated. Tried this successfully on my m2:
Though compiling lotus:
I have xcode 14 locally, I guess brew built hwloc for me, but the Circle config has But lotus still runs, and syncs the chain from a snapshot.
I have an Intel mac in the house I could test the universal binary on just to be sure, but I don't have access to it at the moment, I'll try later in the week. |
@rvagg I'm happy that you have a look. I have almost zero experience with MacOS (and no local machine to test on). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is working as tested both on my m2, and using assets compiled on my m2 used to compile and run lotus on an old intel Macbook 12" which is currently syncing the chain without too much trouble
good to go I'd say
This PR migrated the macos builds in the repo to Apple Silicon executors since the Apple Intel ones are getting deprecated by January 2024. See https://discuss.circleci.com/t/macos-intel-support-deprecation-in-january-2024/48718.
FYI, the builds currently fail with:
I assume it's going to be easier to figure out for maintainers.