Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Non-interactive PoRep #453

Open
wants to merge 6 commits into
base: feat/nv23
Choose a base branch
from
Open

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Apr 23, 2024

This commit adds support for ni-porep.

Also Rust >= 1.70 is needed due to the dependency on home v0.5.9 and fix the corresponding new Clippy warnings.


This is only the Rust side of things, the Go parts are missing.

@cryptonemo
Copy link
Contributor

This needs to be rebased on top of #450, not master

@vmx vmx changed the base branch from master to improved-error-handling April 23, 2024 19:13
@vmx
Copy link
Contributor Author

vmx commented Apr 23, 2024

Also rebased on your branch.

Base automatically changed from improved-error-handling to master April 29, 2024 17:51
This commit adds support for ni-porep.

It also makes CI match the Rust version in the rust-toolchain.toml
@vmx
Copy link
Contributor Author

vmx commented May 7, 2024

I've rebased this PR and also adapted it to the fixed names.

@cryptonemo
Copy link
Contributor

I think this needs to target feat/nv23 and not master. Sound correct, @rjan90?

@rjan90
Copy link
Collaborator

rjan90 commented May 7, 2024

I think this needs to target feat/nv23 and not master. Sound correct, @rjan90?

Yeah, that is correct. That branch was based off master today, so it should not cause any issues.

@vmx vmx changed the base branch from master to feat/nv23 May 7, 2024 15:33
@vmx
Copy link
Contributor Author

vmx commented May 7, 2024

I've changed the base to feat/nv23.

@cryptonemo cryptonemo requested a review from rjan90 May 20, 2024 16:37
rust/src/proofs/types.rs Outdated Show resolved Hide resolved
rust/src/proofs/types.rs Outdated Show resolved Hide resolved
@rvagg rvagg mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants