Non Interactive Proof of Replication #1999
Conversation
shared/src/sector/seal.rs
Outdated
| pub proof: Vec<u8>, | ||
| pub sealed_cid: Cid, // Commr | ||
| pub unsealed_cid: Cid, // Commd | ||
| } |
There was a problem hiding this comment.
Can we do this without introducing a new NISealVerifyInfo type, and thus without a new syscall at all? The proof type carries the information that it is NI, and then determines that certain fields will be ignored.
- deal_ids: already ignored and always empty
- interactive_randomness: let's just specify it shall be zero (and ignored) for NI proofs
There was a problem hiding this comment.
Yeah, that was my initial thinking too. Will change that.
|
This is probably ready for review. We'll need it to land so the actors change can depend on it. @Stebalien the associated FIP is accepted. Can we land this direct to master? |
|
It looks like this doesn't build with the "proofs" feature enabled. |
|
just needs the additional |
True, but I need to change dependancy to the |
A new Filecoin-proofs-api release is expected to be out today (Thursday May 16th), which includes the NI-PoRep registered proofs. |
|
It looks like |
| Ok(Self::StackedDrg2KiBV1_2_Feat_NonInteractivePoRep) | ||
| } | ||
| StackedDRG512MiBV1P1_Feat_NiPoRep => { | ||
| Ok(Self::StackedDrg512MiBV1_2_Feat_NonInteractivecPoRep) |
There was a problem hiding this comment.
this misnaming has been fixed in the newly released filecoin-proofs-api v18.0.1 if you update the dependency here
| Ok(Self::StackedDrg512MiBV1_2_Feat_NonInteractivecPoRep) | |
| Ok(Self::StackedDrg512MiBV1_2_Feat_NonInteractivePoRep) |
No description provided.