fix: make things independent of the Multihash code table #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should now be possible to specify your own Multihash code table.
Stebalien
reviewed
May 3, 2022
|
|
||
| /// An IPLD blockstore suitable for injection into the FVM. | ||
| /// | ||
| /// The cgo blockstore adapter implements this trait. | ||
| pub trait Blockstore { | ||
| /// | ||
| pub trait Blockstore<const S: usize = DEFAULT_MULTIHASH_ALLOC_SIZE> { |
There was a problem hiding this comment.
Being generic over the code type makes sense, but being generic over the size really isn't worth it:
- It will lead to an annoying refactor in the actors (which will have to be backported).
- It will conflict with all open PRs.
There was a problem hiding this comment.
Agreed, it didn't really felt nice anyway. I'll look if I find a better, less intrusive way.
|
Note: don't spend too much time on this right now. I'd like to see how much of breaking change this would be if we only make these types generic over the code, but we're trying to wrap up M1 ASAP so bubbling breaking changes that can be punted till M2 isn't a priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should now be possible to specify your own Multihash code
table.
@Stebalien this one is for you. Please let me know if this is something we want to tackle and whether it's the right direction. Ideally I'd like to use the default alloc value as little as possible and make it explicit most of the time.
It currently build, but I haven't even tried to compile the tests yet, as I'd like to get basic feedback, before I start making everything pretty.