-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented support for chunked transfer-encoding #397
base: master
Are you sure you want to change the base?
Conversation
88ba7dd
to
25f6da9
Compare
AppVeyor fails due to permission issues |
Is there any link with this issue (request/request#2499) ? |
@danielgindi Sorry, somehow I missed it. I'm loving it. Let me try to run it locally for sanity check and I'll check what's up with AppWeird. Thanks a lot. It looks awesome. |
Seems like it's npm@2 issue. Let's update node version (both appveyor and travis) to 6, 8, 10. |
I think that and bumping node versions will bring us to the finish line. Thank you. |
No problem, I found out that that uncovered line will indeed never happen in normal conditions. |
25f6da9
to
03bca4b
Compare
And I'll let you bump the version :-) |
03bca4b
to
a7bc1c3
Compare
@alexindigo any news? currently having to do hacks in code to support this... |
For anyone who ends up here from issues with multipat where you wish to set encoding to chunked. To prevent That will explicitly propagate through length counting and cause resulting total length to be NaN thus stopping If properly documented this might be considered a feature ;) |
@naugtur This is a very nice workaround :-) |
@naugtur you just saved me.... |
This will handles issues like:
request/request#2896
request/request#2488
request/request#2380
request/request#1770