Add build process with browserify (closes #21) #26
Conversation
|
@freeman-lab @rreusser anyone? |
package.json
Outdated
| "scripts": { | ||
| "start": "watchify-server example.js | garnish", | ||
| "test": "standard && browserify test.js | smokestack | tap-spec", | ||
| "build": "browserify demo/index.js -o demo/bundle.js", | ||
| "deploy": "npm run build && surge demo control-panel.surge.sh" | ||
| "build": "browserify -s control index.js -o build/control-panel.js", |
There was a problem hiding this comment.
Would it be appropriate to add the es2040 browserify transform to this, i.e.:
browserify -s control index.js -o build/control-panel.js -t es2040This repo uses template strings (const too, I think?) which at this point are mostly supported, but my iPad, for one, fails with const and template strings so that it's probably best to just transpile to ES5 while we're at it.
|
Thanks for the PR! It seems pretty straightforward and seems like the right move! |
|
Thank you! This plugin looks nicer and has a better api than dat.gui, it's a shame it was usable only with browserify. Happy to help |
|
Oh, whoopsie. I'm glad to help get this merged, but looks like I don't have permissions. /ping @freeman-lab 😄 Also, @marcofugaro It might be of interest that I've been working on a new version of this which you can find here: https://rreusser.github.io/control-panel-2/ https://github.com/rreusser/control-panel-2 It has the additional feature that the state behaves like a regular object. You can wrap it in a UI which connects to events so that modifications feed right back into the UI. It needs some work in order to get it over the line, but the primary goal was to address some recurring needs based on lots of usage of |
|
@rreusser nice! really interesting approach! keep it up! |
|
@freeman-lab You don't want to merge this? |
This library is currently written in node. In this PR, browserify generates that code into a bundle that is usable from a browser and with other build tools that are not browserify.
Closes #21