Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support workspace Cargo.toml with package section #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OlivierLDff
Copy link

This commit also introduce:

  • ✅ Unit test for previous behavior
  • 🐛 make description optional field like in other package (inpired from pyproject)

This commit also introduce:
- ✅ Unit test for previous behavior
- 🐛 make description optional field like in other package
@c4th4r5y5
Copy link
Contributor

c4th4r5y5 commented Jun 16, 2023

Hi @OlivierLDff

Are you aware of any other format distinction for the toml in Rust?

I've dealt with a similar issue when trying to implement the Python preset (#265). It might be worth it to reuse the deep search logic i've put in there to cover more cases that might arise if the format changes.

(For python, I simply do a top-down search of the expected key name and take the first values found. This is somewhat future proof but should require an explicit warning in the readme imo)

@OlivierLDff
Copy link
Author

In rust package are either a top key of the cargo.toml are a workspace package, I never saw anything else and I'm not aware if something else exists

@OlivierLDff
Copy link
Author

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants