Rename string trim functions #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Looks like |
|
It would be good to hear some people chime in here 😃 |
|
I think we should stick to some version of Some alternatives to |
|
That's true. Let's see what people says 😃 |
|
I think I would be in favor of this change, but of course in case we approve it, it will have to be for v2.0 In the meantime it would be interesting to hear other voices. Maybe @cannorin can comment as he added many string functions to the lib. |
wallymathieu
approved these changes
May 21, 2020
gusty
force-pushed
the
master
branch
2 times, most recently
from
32f5c4a
to
f2d1afd
Compare
gusty
force-pushed
the
master
branch
4 times, most recently
from
5c69948
to
9ca5706
Compare
gusty
force-pushed
the
master
branch
2 times, most recently
from
5b61ffc
to
ad56a34
Compare
gusty
force-pushed
the
master
branch
9 times, most recently
from
35b259d
to
ea11a8b
Compare
gusty
force-pushed
the
master
branch
5 times, most recently
from
105ed2c
to
d80a4ad
Compare
wallymathieu
force-pushed
the
master
branch
5 times, most recently
from
f92d910
to
39638fb
Compare
gusty
force-pushed
the
master
branch
6 times, most recently
from
9b34ece
to
b2f3c8c
Compare
gusty
force-pushed
the
master
branch
2 times, most recently
from
484cff5
to
142c806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #288 (comment)