Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose addProtocol #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose addProtocol #388

wants to merge 1 commit into from

Conversation

kamataryo
Copy link
Contributor

@kamataryo kamataryo commented Nov 24, 2023 •
edited

DEM を扱う上で addProtocol を利用したいため露出させたいです。

phanect
phanect approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@phanect phanect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanect phanect phanect approved these changes

@keichan34 keichan34 Awaiting requested review from keichan34

@naogify naogify Awaiting requested review from naogify

@sugama-satsuki sugama-satsuki Awaiting requested review from sugama-satsuki

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamataryo @phanect