Quick self-host #81
Draft
Quick self-host #81
+5,587
−2,121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanect
force-pushed
the
feat-self-host
branch
from
4918a44
to
d9630b8
Compare
Deploying with
|
| Latest commit: |
45ae446
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6759c86.opendata-editor-preview.pages.dev |
| Branch Preview URL: | https://feat-self-host.opendata-editor-preview.pages.dev |
phanect
force-pushed
the
feat-self-host
branch
18 times, most recently
from
fdc3254
to
25c621f
Compare
phanect
force-pushed
the
feat-self-host
branch
5 times, most recently
from
53da452
to
a052fa1
Compare
`devDependencies` are not installed when the npm package is installed.
`path.resolve()` returns clean path (e.g. /path/to/file.tsx) while `path.join()` sometimes returns dirty one (e.g. /path/../to/file.tsx), but since the concatenated path is not displayed to users, dirty path is OK. I chose `path.join()` because I guess generating clean path might take a little bit longer time.
When lerna.json is rewritten by `npm run version`, it forces this coding style.
… CLI Without this change, some modules cannot be resolved on `import`.
This package is source code for https://geolonia.github.io/opendata-editor/
phanect
force-pushed
the
feat-self-host
branch
from
f911b26
to
45ae446
Compare
|
中途半端なところで終わってしまったので、引き継ぎです。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80