Release 3.0

[codeofsumit]

This release branch aims to collect breaking changes until we can release the next major version.
It has to constantly stay in sync with the develop and master branch to avoid extensive merge conflicts down the road.

[Falke-Design]

Should be also removed:

L.PM.Draw.Marker, L.PM.Draw.CircleMarker:

this._map.fire('pm:create', {
      shape: this._shape,
      marker, // DEPRECATED
      layer: marker,
    });

L.PM.Draw.Line:

    // fallback option for finishOnDoubleClick
    // TODO: remove in a later release
    if (this.options.finishOnDoubleClick && !this.options.finishOn) {
      this.options.finishOn = 'dblclick';
    }

L.PM.Map:

enableDraw(shape = 'Polygon', options) {
    // backwards compatible, remove after 3.0
    if (shape === 'Poly') {
      shape = 'Polygon';
    }
   //...


disableDraw(shape = 'Polygon') {
    // backwards compatible, remove after 3.0
    if (shape === 'Poly') {
      shape = 'Polygon';
    }
   //...

[Falke-Design]

Also old button nams in L.PM.Toolbar in addControls() and toggleButton()

    // make button renaming backwards compatible
    if (typeof options.editPolygon !== 'undefined') {
      options.editMode = options.editPolygon;
    }
    if (typeof options.deleteLayer !== 'undefined') {
      options.removalMode = options.deleteLayer;
    }

[Falke-Design]

Thinking of changing the event markerdragstart into vertexdragstart same for the other "marker" events. It would be a clearer name

[Falke-Design]

Remove the first argument e, because it is also in the object:
L.Controls:

  _triggerClick(e) {
    // TODO is this a big change when we change from e to a object with the event and the button? Now it's the second argument
    this._button.onClick(e, { button: this, event: e });
    this._clicked(e);
    this._button.afterClick(e, { button: this, event: e });
  },

[Falke-Design]

Thinking of rename Line to Polyline. To match the leaflet default

[Falke-Design]

Change the option name

editable	false	makes a CircleMarker editable like a Circle

[Falke-Design]

Remove the optional shape it has no function, all shapes will be disabled:

leaflet-geoman/src/js/L.PM.Map.js

Lines 62 to 69 in ff58d54

	disableDraw(shape = 'Polygon') {
	// backwards compatible, remove after 3.0
	if (shape === 'Poly') {
	shape = 'Polygon';
	}
	this.Draw.disable(shape);
	},

[Falke-Design]

Mode.Edit, Mode.Drag, ... add _ to private functions

[Falke-Design]

Make _removeLastVertex() to a public function

[Falke-Design]

L.PM.Map and all Modes change this.map to this._map. Then it is used the same name as in the Draw and Edit Classes

[Falke-Design]

rename _finishShape() and _createMarker to the same name and make it public

[Falke-Design]

Add to all CSS classes the prefix leaflet-geoman. More and more libraries have problems with using the same CSS-Class name. Like .active

[Falke-Design]

Draw.Line uses templineStyle, Draw.Rectangle uses pathOptions.