-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): Add documentation about replay event types #1197
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc @vaind |
|
||
**Additional Item Headers:** | ||
|
||
*None* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe length
is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for replay_event
though right? only replay_recording
which is below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each envelope item needs a length header because a new line character could be present in the item's payload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm we currently do not send a length header for js sdk
src/docs/sdk/replays.mdx
Outdated
| segment_id | number | The segment id. | | ||
| replay_start_timestamp | number | UNIX timestamp of the start of the replay (in seconds). This is only required on the first segment. | | ||
| urls | list[string] | List of URLs in order of visitation. | | ||
| error_ids | list[string] | List of error event ids that occurred during the replay. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be marked as deprecated now that we use event linking on the back end.
Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
Relates to: